Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update where.md to enhance the usability of the example #6399

Open
wants to merge 6 commits into
base: current
Choose a base branch
from
Open

Update where.md to enhance the usability of the example #6399

wants to merge 6 commits into from

Conversation

brian-franklin
Copy link

@brian-franklin brian-franklin commented Oct 31, 2024 •
edited
Loading

The example on the page is useful; however, it is rigid in only allowing a 3 day look back. Adjusting the pattern to include a number value and a macro that performs a regex search to set the dateadd logic to whatever value is configured in the test. This allows for reusbaility of the macro for different lookback days.

What are you changing in this pull request and why?

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

@brian-franklin
Update where.md to enhance the usability of the example
07fef64 
The example on the page is useful; however, it is rigid in only allowing a 3 day look back. Adjusting the pattern to include a number value and a macro that performs a regex search to set the dateadd logic to whatever value is configured in the test. This allows for reusbaility of the macro for different lookback days.
@brian-franklin brian-franklin requested a review from a team as a code owner October 31, 2024 22:34
@welcome Welcome
Copy link

welcome bot commented Oct 31, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2024

@brian-franklin is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the content Improvements or additions to content label Oct 31, 2024
@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 31, 2024
@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Oct 31, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 20, 2024 4:46pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brian-franklin @runleonarun @mirnawong1